Skip to content

feat: add Register function to DA registry#721

Merged
tzdybal merged 1 commit intomainfrom
tzdybal/register_da
Feb 3, 2023
Merged

feat: add Register function to DA registry#721
tzdybal merged 1 commit intomainfrom
tzdybal/register_da

Conversation

@tzdybal
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal commented Jan 31, 2023

Resolves #715.

@tzdybal tzdybal requested a review from a team January 31, 2023 09:37
@tzdybal tzdybal self-assigned this Jan 31, 2023
@tzdybal tzdybal requested review from S1nus, nashqueue and tuxcanfly and removed request for a team January 31, 2023 09:37
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 55.15% // Head: 55.16% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (88a3d3e) compared to base (b82de97).
Patch coverage: 75.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
+ Coverage   55.15%   55.16%   +0.01%     
==========================================
  Files          52       52              
  Lines        9755     9763       +8     
==========================================
+ Hits         5380     5386       +6     
- Misses       3577     3579       +2     
  Partials      798      798              
Impacted Files Coverage Δ
da/registry/registry.go 91.30% <75.00%> (-8.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread da/registry/registry_test.go
@tzdybal tzdybal requested a review from nashqueue January 31, 2023 15:31
@tzdybal tzdybal enabled auto-merge (squash) February 3, 2023 22:28
@tzdybal tzdybal force-pushed the tzdybal/register_da branch from 88a3d3e to 3146a21 Compare February 3, 2023 22:34
@tzdybal tzdybal merged commit 9f954d6 into main Feb 3, 2023
@tzdybal tzdybal deleted the tzdybal/register_da branch February 3, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable registering custom DA layer

4 participants